-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] release1.0/6 -> develop 머지하기 #306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 로딩창 배경 컬러 추가
- 로딩창 배경 컬러 적용
- 명함 모음 무한스크롤 cardsCollectionView 에만 적용
[CHORE] #291 - 로그인 버튼 레이아웃 조정
[CHORE] #294 - 앱 언어 한국어로 변경하기
[FEAT] 온보딩 스플래시 뷰에 연결
[FIX] #298 -그룹명 dynamic Cell 코드 수정
- 메인 로딩창 추가 - 명함생성시에 노티를 통해서 main 으로 isAfterCreation 을 true 로 해서 명함생성 후에는 스크롤 1로 이동 - 명함모음에서도 로딩창 추가 - 메인에 viewWillAppear 를 사용해서 스와이프로 명함 리스트에서 넘어와도 리로드
[FIX] #301 - 그룹 편집 뷰 그룹명 길이 제한
[FIX] #286 - 무한스크롤 오프셋 개선 및 로딩창 수정
[CHORE] #304 - 카카오 로그인 버튼 수정
dlwns33
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
mini-min
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
chore
[CHORE] #291 - 로그인 버튼 레이아웃 조정 #295 [CHORE] #294 - 앱 언어 한국어로 변경하기 #297 [CHORE] #304 - 카카오 로그인 버튼 수정 #305
fix
[FIX] #298 -그룹명 dynamic Cell 코드 수정 #300 [FIX] #301 - 그룹 편집 뷰 그룹명 길이 제한 #302 [FIX] #286 - 무한스크롤 오프셋 개선 및 로딩창 수정 #303
feat
[FEAT] 온보딩 스플래시 뷰에 연결 #299